lkml.org 
[lkml]   [2004]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Kernel-janitors] [PATCH 2.6][10/12] prep_pci.c replace pci_find_device with pci_get_device
--On Saturday, October 09, 2004 10:05:35 AM -0700 Scott Feldman <sfeldma@pobox.com> wrote:

> On Thu, 2004-10-07 at 16:40, Hanna Linder wrote:
>> @@ -1102,7 +1102,7 @@ prep_pib_init(void)
>> }
>> }
>>
>> - if ((dev = pci_find_device(PCI_VENDOR_ID_WINBOND,
>> + if ((dev = pci_get_device(PCI_VENDOR_ID_WINBOND,
>> PCI_DEVICE_ID_WINBOND_82C105, dev))){
>> if (OpenPIC_Addr){
>> /*
>
> Missing pci_dev_put(dev) cleanup?
>
> -scott
>
>

Hi Scott,

It doesnt need an explicit dev_put because the pci_dev * is used as the *from pointer
in the pci_get_device call which will do the dev_put automaticaly.

Hanna

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:06    [W:0.063 / U:1.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site