lkml.org 
[lkml]   [2004]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ide-dma blacklist behaviour broken
On Sun, Oct 10 2004, Bartlomiej Zolnierkiewicz wrote:
> > --- drivers/ide/ide-dma.c~ 2004-10-05 16:11:49.631910586 +0200
> > +++ drivers/ide/ide-dma.c 2004-10-05 16:21:58.828330845 +0200
> > @@ -354,11 +355,13 @@
> > struct hd_driveid *id = drive->id;
> > ide_hwif_t *hwif = HWIF(drive);
> >
> > - if ((id->capability & 1) && hwif->autodma) {
> > - /* Consult the list of known "bad" drives */
> > - if (__ide_dma_bad_drive(drive))
> > - return __ide_dma_off(drive);
> > + /* Consult the list of known "bad" drives */
> > + if (__ide_dma_bad_drive(drive)) {
> > + __ide_dma_off(drive);
> > + return 1;
> > + }
> >
> > + if ((id->capability & 1) && hwif->autodma) {
> > /*
> > * Enable DMA on any drive that has
> > * UltraDMA (mode 0/1/2/3/4/5/6) enabled
>
> Is __ide_dma_bad_drive() check still needed?
> Doesn't __ide_dma_on() fix handle this now?

Yeah, we can solely rely on that if we so wish.

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:06    [W:0.079 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site