Messages in this thread | | | Date | Fri, 9 Jan 2004 13:49:42 +0000 | From | Christoph Hellwig <> | Subject | Re: [patch] 2.6.1-rc2-mm1: qla1280.c doesn't compile |
| |
On Fri, Jan 09, 2004 at 02:52:30AM +0100, Adrian Bunk wrote: > I got the following compile error when trying to compile this driver > statically into a kernel with hotplug enabled:
Jes, that's your ifdef-magic around around qla1280_remove_one.. Do you remember why you added it? The only case we don't need it is when the driver is builtin and CONFIG_HOTPLUG is not set - and in that case __devexit should get rid of it for us.
> Since I don't see a good reason why qla1280_remove_one is #ifdef'ed out > in the non-modular case the patch below fixes this problem by removing > two #ifdef's.
The patch looks good to me. In fact that's how it was in the patch I sent to Jes.. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |