Messages in this thread | | | Date | Sat, 10 Jan 2004 10:26:34 +1300 | From | Nigel Cunningham <> | Subject | Re: PATCH 1/2: Make gotoxy & siblings use unsigned variables |
| |
Hi.
Of course you're right about 2^31 columns, but the rest of the code used unsigned ints as well, not because it expects 2^31 columns, but because (if I understand the code right), the numbers can be part of escape sequences... I'm looking at csi_m in vt.c.
Regards,
Nigel
On Sat, 2004-01-10 at 09:33, Andries Brouwer wrote: > >> Shouldn't we be using "size_t" for unsigned int > > > You might be right. I was just being consistent with the other definitions. > > These are character positions on a screen. > When did you last see a console in text mode with a line length > of more than 2^31 ? > > If you go for a minimal patch then you should replace "char" > in one or two places by "unsigned char" and that is all. > > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- My work on Software Suspend is graciously brought to you by LinuxFund.org. [unhandled content-type:application/pgp-signature] | |