Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH 1/2] kthread_create | Date | Thu, 08 Jan 2004 11:33:43 +1100 |
| |
In message <Pine.LNX.4.44.0401062314070.1030-100000@bigblue.dev.mdolabs.com> you write: > On Wed, 7 Jan 2004, Rusty Russell wrote: > > > Latest version of patch, and code which uses it. It's actually quite > > neat now. Changes since first version: > > Yes, I like this better. Without any doubt, the removal of sync'd start > function simplified things a lot.
Yeah, I thought you would: makes our previous debates moot so we can be friends again 8)
The reason I did the startfn thing originally is for the hotplug CPU code: I wanted to make sure the thread gets onto the CPU while we're in the notifier, so it doesn't go down again before the thread does set_cpus_allowed(). Not a problem in practice, but it's nice to have the BUG_ON(smp_processor_id() != cpu) in the code.
kthread_bind() solves this neatly, and we need it for migration_thread anyway (which is the one thread where being on the right CPU effects correctness, not just performance).
Cheers! Rusty. -- Anyone who quotes me in their sig is an idiot. -- Rusty Russell. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |