lkml.org 
[lkml]   [2004]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patches in this message
/
Date
From
SubjectUse of floating point in the kernel
Hi

There are a few instances of use of floating point in 2.6,

--- linux-2.6.0-1.30/drivers/media/dvb/ttpci/av7110.c~ 2004-01-07 23:14:14.000000000 +0200
+++ linux-2.6.0-1.30/drivers/media/dvb/ttpci/av7110.c 2004-01-07 23:14:14.000000000 +0200
@@ -2673,9 +2673,9 @@
buf[1] = div & 0xff;
buf[2] = 0x8e;

- if (freq < (u32) 16*168.25 )
+ if (freq < 2692 ) /* 16*168.25 */
config = 0xa0;
- else if (freq < (u32) 16*447.25)
+ else if (freq < 7156) /* 16*447.25 */
config = 0x90;
else
config = 0x30;
(If I'm not mistaken a similar patch for this has already been sent to
Linus, just making sure the DVB people get this in their trees as well)
(u32) (16*168.25) would work too, I suppose.

The other case is a bit more widespread, patch below is mostly rhetoric :-)
http://www.winischhofer.net/linuxsisvga.shtml#download contains the latest version
of the sisfb that doesn't use floating point at all, so that is certainly the better
option.

--- linux-2.6.0-1.30/drivers/video/sis/sis_main.c~ 2004-01-08 01:27:44.909006216 +0200
+++ linux-2.6.0-1.30/drivers/video/sis/sis_main.c 2004-01-08 01:28:19.111806600 +0200
@@ -616,6 +616,7 @@
var->left_margin + var->xres + var->right_margin +
var->hsync_len;
unsigned int vtotal = 0;
+#error Use of floating point in the kernel is NOT safe!
double drate = 0, hrate = 0;
int found_mode = 0;
int old_mode;
--- linux-2.6.0-1.30/drivers/video/Kconfig~ 2004-01-08 01:25:37.570364632 +0200
+++ linux-2.6.0-1.30/drivers/video/Kconfig 2004-01-08 01:25:37.571364480 +0200
@@ -704,7 +704,7 @@

config FB_SIS
tristate "SIS acceleration"
- depends on FB && PCI
+ depends on FB && PCI && BROKEN
help
This is the frame buffer device driver for the SiS 630 and 640 Super
Socket 7 UMA cards. Specs available at <http://www.sis.com.tw/>.

--
Pekka Pietikainen
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:59    [W:0.037 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site