lkml.org 
[lkml]   [2004]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] 2.6.1-rc2 ide barrier support
    Date
    On Wednesday 07 of January 2004 14:43, Jens Axboe wrote:
    > Bart, would you care to review the ide bits for sanity?

    Yep, here is just a first sight...

    > + struct request *flush_rq = &HWGROUP(drive)->wrq;

    I want to remove drive->wrq in the future.

    > + memset(drive->special_buf, 0, sizeof(drive->special_buf));
    > +
    > + ide_init_drive_cmd(flush_rq);
    > +
    > + flush_rq->flags = REQ_DRIVE_TASK;
    > + flush_rq->buffer = drive->special_buf;
    > + flush_rq->special = rq;
    > + flush_rq->buffer[0] = WIN_FLUSH_CACHE;
    > + flush_rq->nr_sectors = rq->nr_sectors;

    I think you should try use REQ_DRIVE_TASKFILE,
    instead of adding drive->special_buf.

    > +/*
    > + * FIXME: probably move this somewhere else, name is bad too :)
    > + */
    > +static sector_t ide_get_error_location(ide_drive_t *drive, char *args)

    This is probably useful in few other places.

    --bart

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:59    [W:0.021 / U:212.448 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site