Messages in this thread | | | Date | Mon, 5 Jan 2004 19:16:27 +0100 | From | Jens Axboe <> | Subject | Re: Possibly wrong BIO usage in ide_multwrite |
| |
On Mon, Jan 05 2004, Bartlomiej Zolnierkiewicz wrote: > On Monday 05 of January 2004 17:49, Jens Axboe wrote: > > On Mon, Jan 05 2004, Bartlomiej Zolnierkiewicz wrote: > > > > calling end_request with a null sector count, ide_end_request will then > > > > take hard_nr_sectors which will end the whole request even if only one > > > > bio was finished, huh? Am I missing something here? > > > > > > No, it is used mainly to fail requests. > > > > > > This hack should be later removed with care > > > (there is some strange comment about locking). > > > > IIRC, it's due to it not always being safe to inspect rq state outside > > of ide_lock. So that makes 0 a magic value that just means 'end the > > first chunk' for ide_end_request(). > > Why/when it is not safe to do?
You would need to read hwgroup->rq.
-- Jens Axboe
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |