Messages in this thread | | | Date | Sat, 3 Jan 2004 14:43:37 +1100 | From | Rusty Russell <> | Subject | Re: 2.6.0-test6: APM unable to suspend (the 2.6.0-test2 saga continues) |
| |
On Wed, 31 Dec 2003 13:40:33 +0100 Vojtech Pavlik <vojtech@suse.cz> wrote: > > +#undef MODULE_PARAM_PREFIX > > +#define MODULE_PARAM_PREFIX /* empty */ > > + > > static unsigned int i8042_noaux; > > module_param(i8042_noaux, bool, 0); > > Well, I think it might be cleaner to just drop the i8042_ prefix and go > with the "i8042." prefix if that's the 2.6 way. It'll annoy a couple > people, but's it's the way to go in the future.
Yeah, unless there's a good reason, it's nicer if there's symmetry so people can guess how to pass params.
Thanks, Rusty. -- there are those who do and those who hang on and you don't see too many doers quoting their contemporaries. -- Larry McVoy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |