Messages in this thread | | | Date | Tue, 27 Jan 2004 19:02:51 +0100 | From | Andi Kleen <> | Subject | Re: [PATCH] kgdb-x86_64-support.patch for 2.6.2-rc1-mm3 |
| |
On 27 Jan 2004 12:43:20 -0500 Jim Houston <jim.houston@comcast.net> wrote:
. > > It looks like we were working in lock step. I had been meaning to > update the patch so when I saw that Andrew had dropped it from > 2.6.2-rc1-mm3 it seemed like a good time. > > I'll leave it to you and Andrew to decide how we should resolve our > conflicting patches.
If yours works on ethernet please use yours. Mine didn't.
> arch/x86_64/Kconfig > arch/x86_64/Kconfig.kgdb > We used a different approach to selecting DEBUG_INFO. > I was not really happy with the way select DEBUG_INFO worked.
You reverted it back?
What I did was to change all not really kgdb specific CONFIG_KGDB uses in the main kernel with CONFIG_DEBUG_INFO (mostly CFI support). I don't feel strongly about it, but this way there is no reference to an unknown config symbol in mainline. Also DEBUG_INFO including CFI makes sense I think.
Putting the kgdb options into a separate sourced file is a good idea. This should decrease future conflicts.
> include/asm-x86_64/kgdb_local.h > This file seems to be missing from your patch. Maybe I'm > missing something. In my patch it is a copy of the i386 > version.
Probably my fault.
-Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |