lkml.org 
[lkml]   [2004]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] fix for ide-scsi crash

    >> Agree, it's a bug. Pascal, care to take a stab at fixing it? You're the
    >> most avid ide-cd non-2kb block size user at the moment :)

    > There's a lot of macros related to sector sizes in ide-cd.h. I suppose
    > all that would need to be changed to depend on the real hardware sector
    > size?

    I've actually looked at the code now and it seems that it might be
    quite easy to fix this, after all.

    I have a question about cdrom_start_read_continuation:

    Variables called nframes and frames are computed but never used. Only
    nskip actually gets factored into the request:

    rq->current_nr_sectors += nskip;

    The others are local vars and never get assigned to anything more
    global. So I conclude they are meaningless? I ask because this
    is one of the places that uses SECTORS_PER_FRAME and it doesn't make
    sense to me.

    Unrelated question:

    Later on, the code decides to use DMA only for requests aligned
    on a SECTORS_PER_FRAME boundary. Where does this limitation come from?
    Does it come from the drive, so that alignment to 512 byte would be
    enough on a drive with 512 byte sectors?

    I've actually ordered some 512 byte sector MO discs today and will try
    to get them working with ide-cd once they arrive here.

    --
    Ciao,
    Pascal

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:00    [W:0.020 / U:0.544 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site