lkml.org 
[lkml]   [2004]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] 2.6.1: Update PCI Name database, fix gen-devlist.c for long device names.
At 05:30 PM 19/01/2004 -0800, you wrote:

>On Sat, Jan 17, 2004 at 11:39:00AM +0100, Martin Mares wrote:
>> Hello!
>>
>> > * Updates pci.ids with a snapshot from http://pciids.sourceforge.net/ as at
>> > 14 Jan 04.
>> > * Fixes gen-devlist.c to truncate long device names rather than reject the
>> > whole database
>> > (previously the latest databases had some devices that were too long and
>> > caused a kernel with the latest db to fail to compile)
>>
>> I think it would be better to increase the name length limit, the long entries
>> really have useful information at the end :)
>
>That's probably a good idea. Kieran, care to make up a patch to do
>this?
>
>thanks,
>
>greg k-h

Done (see other message).. but does anyone know why the name size limit was introduced in 2.5? Saving memory? (all of 30-odd bytes per device, say 480 bytes in an average system? seems silly to reduce functionality that much to achieve such a tiny space saving; I mean it's understandable perhaps on an embedded system, but you wouldn't be compiling the database in then :)

Cheers

Kieran
\
 
 \ /
  Last update: 2005-03-22 14:00    [W:0.141 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site