[lkml]   [2004]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] "gconfig" removed root folder...
    On Jan-17 2004, Sat, 22:47 +0100
    Romain Lievin <> wrote:

    > > On Jan-15 2004, Thu, 22:44 +0100
    > > Romain Lievin <> wrote:
    > >
    > > > + if(stat(fn, &sb) == -1) return;
    > >
    > > Codingstyle inconsistency.
    > What should I write then ? Your piece of advice may make me better.

    Read Documentation/CodingStyle. It is loosely based on the original
    K&R style, where (the scarce) language constructs' arguments' opening
    parenthese is prepended by a space, whereas with functions and macros
    it is not. I.e., one writes 'if (...)', 'while (...)', 'foo(bar)', etc.

    Also, your explicit casts could use extra whitespace, like so:
    "a = (int *) b;" not "a = (int *)b;"

    When submiting code to an existing file, the general rule of thumb
    is not to disrupt the style of that particular file, regardless
    of what it appears to be. You have managed to break this rule
    _and_ the official CodingStyle.

    Tomas Szepe <>
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2005-03-22 14:00    [W:0.019 / U:7.144 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site