Messages in this thread | | | Date | Sat, 17 Jan 2004 20:10:00 +0000 | From | viro@parcelfa ... | Subject | Re: [RFC] kill sleep_on |
| |
On Sat, Jan 17, 2004 at 07:28:21PM +0000, David Woodhouse wrote: > On Sat, 2004-01-17 at 19:43 +0100, Manfred Spraul wrote: > > Virtually all sleep_on / interruptible_sleep_on users are racy. Actually > > there is only one safe case: if both wakeup and sleep happen under > > lock_kernel. > > Any objections against killing it entirely? Or what about marking it as > > deprecated, as the first step towards killing it? > > > > I'll follow with two patches that remove it from shaper and sunrpc/sched > > - shaper is racy, rpciod_down is only safe if called with lock_kernel. > > Deprecate it in 2.7.0 and add BUG_ON(BKL not held) to it. Not before > time.
We need to remove racy uses anyway - that can't wait for 2.7. And I really wonder if there will be anything left after that - right now only reiserfs uses look like something that might be not immediately broken.
AFAICS, _all_ uses of sleep_on() in drivers are broken in one way or another and BKL won't help them. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |