Messages in this thread | | | Date | Fri, 16 Jan 2004 14:07:28 +0000 | From | Christoph Hellwig <> | Subject | Re: KGDB 2.0.3 with fixes and development in ethernet interface |
| |
On Fri, Jan 16, 2004 at 01:58:06PM +0100, Pavel Machek wrote: > ++int kgdbeth_thread(void *data) > ++{ > ++ struct net_device *ndev = (struct net_device *)data; > ++ daemonize("kgdbeth"); > ++ while (!ndev->ip_ptr) { > ++ schedule(); > ++ } > ++ debugger_entry(); > ++ return 0; > > Don't you need some locking around ndev->ip_ptr? [Okay, it probably > only matters on SMP, so it is not causing your problems..]
Not to mention it should use a proper wait_event instead of this really stupid loop.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |