Messages in this thread | | | Date | Thu, 15 Jan 2004 21:14:02 -0800 | From | Paul Jackson <> | Subject | Re: seperator error in __mask_snprintf_len |
| |
I give, Joe. Given the several details that are better with your solution, I endorse your solution, with the couple of minor edits you have in the pipeline.
It pains me to see the minor code growth (parsing went from 391 bytes of machine code to 625), with non-trivial code duplication of the simple_stroull() routine, and admitted increase in code complexity.
But, yes, better bits than bytes, better not to alloca(), and better using existing bitops than misplaced arch dependencies.
And better you than me ... tag - you're it <grin>.
Bonus question:
Should any of the other inline routines in include/bitmap.h be moved to your new file lib/bitmap.c?
Others have commented that too much stuff is marked inline, and this might be such a case.
For example, I count about a dozen copies of bitmask_empty(), mostly as cpus_empty(), in various generic and i386 files, each one worth perhaps 80 bytes of kernel text space.
-- I won't rest till it's the best ... Programmer, Linux Scalability Paul Jackson <pj@sgi.com> 1.650.933.1373 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |