Messages in this thread Patch in this message | | | Date | Wed, 14 Jan 2004 16:13:24 -0800 | From | Stephen Hemminger <> | Subject | Re: [PATCH 2.6.X] SIOCSIFNAME wilcard suppor & name validation |
| |
Bug: dev_alloc_name returns the number of the slot used, so comparison needs to be < 0.
diff -Nru a/net/core/dev.c b/net/core/dev.c --- a/net/core/dev.c Wed Jan 14 16:09:02 2004 +++ b/net/core/dev.c Wed Jan 14 16:09:02 2004 @@ -718,7 +718,7 @@ if (strchr(newname, '%')) { int err = dev_alloc_name(dev, newname); - if (err) + if (err < 0) return err; strcpy(newname, dev->name); } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |