[lkml]   [2004]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [I810_AUDIO] 1/x: Fix wait queue race in drain_dac
Herbert Xu wrote:
> Hi:
> This is the first of a number of patches to fix DMA bugs in the
> OSS i810_audio driver.
> This particular one fixes a textbook race condition in drain_dac
> that causes it to timeout when it shouldn't.


Thanks much for these i810_audio patches. I've been meaning to review
them in-depth for some time.

Could you be kind and "spell out" the patch-1 race for me?

Also, it seems to me that you would want to check for signal_pending()
(a) just after the schedule_timeout(), and
(b) -after- testing the 'signals_allowed' variable ;-)



To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2005-03-22 14:00    [W:0.092 / U:6.324 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site