[lkml]   [2004]   [Jan]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [Dri-devel] 2.6 kernel change in nopage
    On Thu, 2004-01-01 at 13:10, Arjan van de Ven wrote:
    > On Thu, 2004-01-01 at 13:03, Michel Dänzer wrote:
    > > How does this patch look?
    > ugly.
    > I find using #defines for function arguments ugly beyond belief and
    > makes it really hard to look through code. I 10x rather have an ifdef in
    > the function prototype (which then for the mainstream kernel drm can be
    > removed for non-matching versions) than such obfuscation.

    That doesn't strike me as particularly beautiful either... is it really
    easier for merges, considering that the ugly way is kinda needed for
    functions which take different arguments on BSD anyway?

    Earthling Michel Dänzer | Debian (powerpc), X and DRI developer
    Software libre enthusiast |

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2005-03-22 13:59    [W:0.028 / U:212.412 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site