Messages in this thread | | | Date | Tue, 9 Sep 2003 07:40:12 +0100 | From | Christoph Hellwig <> | Subject | Re: [Patch] asm workarounds in generic header files |
| |
On Mon, Sep 08, 2003 at 06:04:40PM -0700, Siddha, Suresh B wrote: > Intel ecc compiler doesn't support inline assembly. > Attached patch is required to enable linux kernel build with Intel ecc compiler. > Please apply.
No. Currently kernel is supposed to be GNU C. Using C89/C99 constructs instead of GCCisms is fine and a good idea where it makes code more readable and doesn't degrade performace. Adding hacks for propritary compilers is a very bad idea.
I can't see how you can compile the kernel with theses few changes without inline assembly anyway..
Could you try to test your RELOC_HIDE version with various gcc versions and maybe as some gcc gurus whether it's fine? It would defintily fall into category (1) above. You'd need to come up with something nicer for barrier(), though..
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |