Messages in this thread | | | Date | Tue, 9 Sep 2003 21:55:49 +0200 | From | Jens Axboe <> | Subject | Re: [PATCH] blk API update (and bug fix) to CDU535 cdrom driver |
| |
On Tue, Sep 09 2003, Felipe W Damasio wrote: > Hi Jens, > > Jens Axboe wrote: > >held! Ugh, and the request function do_cdu535_request calls > >schedule_timeout with the queue lock held (that is held when that > >function is entered), that is very buggy as well. Should also use > >set_current_state() right above that call, not open code it (that also > >misses a memory barrier). Same function also has problems with request > >handling. You should kill: > > > > if (!(req->flags & REQ_CMD)) > > continue; /* FIXME */ > > > >that is very broken, make that: > > > > if (!blk_fs_request(req)) { > > end_request(req, 0); > > continue; > > } > > > >and kill these two lines: > > > > if (rq_data_dir(req) != READ) > > panic("Unknown SONY CD cmd"); > > > >they are screwy too. > > > >Care to fix the things I outlined above? > > This patch I think fixes all these, doesn't it? > > It applies on top of my latest cli-sti-removal patch that I sent you.
That needed changes too, as per my last mail. Please send one complete patch with all the fixes in, thanks.
-- Jens Axboe
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |