Messages in this thread | | | Date | Mon, 8 Sep 2003 12:59:32 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH] Re: today's futex changes |
| |
Jamie Lokier <jamie@shareable.org> wrote: > > Andrew Morton wrote: > > Rusty Russell <rusty@rustcorp.com.au> wrote: > > > D: 4) Andrew Morton says spurious wakeup is a bug. Catch it. > > > > Yes, but going BUG() is a bit rude. We can detect the error, we can > > recover from it and it doesn't cause any user data corruption or anything. > > A rude printk is all that is needed here. > > Well, it should really _never_ happen. We are very careful. Is > there something like BUG() which doesn't terminate the process? >
A WARN_ON(1) is good enough. It will spit a stack dump and we will get to hear about it. Going BUG merely reduces the chances of the info hitting the logs and irritates our testers.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |