lkml.org 
[lkml]   [2003]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [BK PATCH] build: config vs. everything else
On Mon, 8 Sep 2003, Sam Ravnborg wrote:
>> The "bk send" is attached. Below is the diff. Excuse the "@/bin/true"...
>> It's the fastest way to get make to shutup.
>@: is faster, and used by kbuld today.

Noted.

>> +scripts/fixdep:
>> + $(Q)$(MAKE) $(build)=scripts fixdep
>Try to avoid special targets when the full name is OK.
>No need for the fixdep target in scripts/Makefile

I seem to recall doing it this way for some reason. But, the logic is the
same. Oh, now I remember... there has to be an explicit target to get
make to not say "already up to date."

>> targets += elfconfig.h
>> +
>Avoid random white space changes.

Then leave a blank line at the end of the file :-)

>> --- 1.9/scripts/kconfig/Makefile Sun Aug 31 19:13:49 2003
>> +++ 1.10/scripts/kconfig/Makefile Fri Sep 5 22:25:25 2003
>> @@ -21,7 +21,7 @@
>> $< -o arch/$(ARCH)/Kconfig
>>
>> silentoldconfig: $(obj)/conf
>> - $< -s arch/$(ARCH)/Kconfig
>> + $(Q)$< -s arch/$(ARCH)/Kconfig
>Unrelated change.

Strictly speaking...

>> --- 1.9/scripts/kconfig/conf.c Fri Jun 6 10:51:38 2003
>> +++ 1.10/scripts/kconfig/conf.c Fri Sep 5 22:25:25 2003
>> @@ -532,7 +532,8 @@
>> }
>> break;
>> case ask_silent:
>> - if (stat(".config", &tmpstat)) {
>> + name = ".config";
>> + if (stat(name, &tmpstat)) {
>> printf("***\n"
>> "*** You have not yet configured your kernel!\n"
>> "***\n"
>> @@ -541,6 +542,8 @@
>> "***\n");
>> exit(1);
>> }
>> + conf_read(name);
>> + break;
>
>What is the purpose of this change?
>If it fixes kconfig behaviour it should go separate to Roman Zippel.

"-s" (silent) should actually *be* silent. If conf_read() is called without
a config file, it isn't silent. (The use of 'name' is merely an optimization.)

--Ricky


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:48    [from the cache]
©2003-2011 Jasper Spaans