lkml.org 
[lkml]   [2003]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2] Little fixes to previous futex patch
On Thu, 4 Sep 2003, Jamie Lokier wrote:
> Hugh Dickins wrote:
> >
> > You're assuming that one call to sys_remap_file_pages precisely populates
> > a whole vma: no, it's quite likely it'll just do a single page of the vma.
>
> What are you talking about? The condition for clearing VM_NONLINEAR
> is an explicit check to see if the range to be populated covers the
> whole vma.

I apologize, I'm just not reading, am I? Thanks for re-explaining.

You're right, the condition on clearing is fine. It's the (lack of
condition on) setting that's over-enthusiastic, should be saying:

if (start - vma->vm_start != (pgoff - vma->vm_pgoff) << PAGE_SHIFT)
vma->vm_flags |= VM_NONLINEAR;

(Unless I'm making a fool of myself again.)

Hugh

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:48    [W:0.103 / U:0.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site