Messages in this thread | | | Subject | RE: [PATCH] linux-2.6.0-test4_cyclone-hpet-fix_A0 | Date | Thu, 4 Sep 2003 11:23:39 -0700 | From | "Pallipadi, Venkatesh" <> |
| |
> -----Original Message----- > From: john stultz [mailto:johnstul@us.ibm.com] > Sent: Thursday, September 04, 2003 10:54 AM > To: Pallipadi, Venkatesh > Cc: Andrew Morton; lkml > Subject: RE: [PATCH] linux-2.6.0-test4_cyclone-hpet-fix_A0 > > > On Thu, 2003-09-04 at 10:21, Pallipadi, Venkatesh wrote: > > > How about the attached patch (against mm4), that moves all > > calibrate tsc functions into a common file, avoiding the > duplication. > > This time I could successfully compile cyclone timer too > :). However, > > Looks better, any reason calibrate_tsc and calibrate_tsc_hpet can't be > unified (it looks like the same basic code just talking to different > hardware)? I was planning on giving that a shot later today.
The best solution will be to unify calibrate_tsc and calibrate_tsc_hpet. Only issue is, we need to switch between pit based mach_count* routines and HPET based ones at runtime. As we want to use pit, even when HPET is
configured in and is not available in the hardware. So, "mach_timer.h" mechanism may not work as is.
> > > I had to do an unrelated one line change in fixmap (last chunk in > > the patch) to compile for summit. > > Is this just an -mm only thing (2.5 has _X86_CYCLONE_TIMER > everywhere)?
Yes. This seems to be mm4 only issue, coming from 4G-4G patch and cyclone-fixmap-fix.patch
Thanks, -Venkatesh - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |