lkml.org 
[lkml]   [2003]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: 2.6.0-test6: more __init bugs
From
Date
On Tue, 2003-09-30 at 02:42, Corey Minyard wrote:
> This is not actually a bug, but it may be bad style (and thus could lead
> to a bug). It is possible that something that uses IPMI can do some
> IPMI things before IPMI is initialized. This can only happen during
> initialization, though. Thus the check; once IPMI is initialized the
> function will never be called.
>
> What's the opinion on this? Should I just force IPMI users to
> initialize after IPMI?

Thanks for looking at it. Would it be reasonable to fail if a client
tries to use the ipmi interface before it is initialized? That would be
a simple change, e.g.:

if (!initialized)
return -ENODEV;

Best,
Rob


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:49    [W:0.076 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site