lkml.org 
[lkml]   [2003]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: 2.6.0-test6: a few __init bugs
On Mon, Sep 29, 2003 at 02:58:12PM -0700, Robert T. Johnson wrote:
> ** Possible bug:
> ** drivers/pci/quirks.c:asus_hides_smbus_hostbridge() (__init)
> in table: drivers/pci/quirks.c:pci_fixups (not __init)
> indirect call f->hook(): drivers/pci/quirks.c:pci_do_fixups() (not __init)
> called by: drivers/pci/quirks.c:pci_fixup_device() (not __init)
> called by: drivers/pci/probe.c:pci_scan_slot() (not __init)
> called by lots of hotplug enable() functions, e.g.
> drivers/pci/hotplug/ibmphp_core.c:ibm_configure_device() (not __init)
> called by drivers/pci/hotplug/ibmphp_core.c:enable_slot() (not __init)
>
> Note: It looks like this may have been originally designed to initialize the
> pci bus at startup, but has been re-used in the hotplug code, which means it
> can be run after the __init segments have gone away.
>
> Fix: Delete all the __init declarations on the quirks hooks.

No, this was discussed a lot a year or so ago. We don't currently have
anything in the quirks table that can be hotplug added as far as I know.
So it's safe for us to throw those quirk entries away.

Yeah, it doesn't make automated test tools easy for this case, sorry.

Hope this helps.

greg k-h

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:49    [W:0.049 / U:0.660 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site