lkml.org 
[lkml]   [2003]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch][2.6.0-test6] ALSA pci Kconfig polishes
    On Mon, Sep 29, 2003 at 05:08:45AM +0200, Ram?n Rey Vicente wrote:
    > Hi.
    >
    > I think the ALSA pci devices must select the GAMEPORT option
    > automatically instead of depends on GAMEPORT.
    >
    > The GAMEPORT is a feature of the device, is not a requisite.

    This patch makes GAMEPORT required, while actually it's only required
    to not be a module if the sound driver is builtin. See my earlier mail
    on the subject for the details:
    http://marc.theaimsgroup.com/?l=linux-kernel&m=106479206731633&w=2

    A better fix would be to revert the change in sound/pci/Kconfig from
    CONFIG_SOUND_GAMEPORT to CONFIG_GAMEPORT back to
    CONFIG_SOUND_GAMEPORT, or just drop this dependency for ALSA and let
    the #ifdefs in the code take care of it. Forcing the gameport to be
    compiled in when it's not necessary is bloat, IMHO.
    --
    Muli Ben-Yehuda
    http://www.mulix.org

    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2005-03-22 13:48    [W:0.022 / U:0.596 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site