lkml.org 
[lkml]   [2003]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ide-io.c, kernel 2.4.22 Fix for IO stats in /proc/partitions, was Re: sard/iostat disk I/O statistics/accounting for 2.5.8-pre3

On 09.15, Chad Talbott wrote:
> I found the cause of ide disks' ios_in_flight going negative in
> /proc/partitions.
[...]
>
> --- linux-2.4.18-old/drivers/ide/ide-io.c 15 Sep 2003 17:41:32 -0000
> +++ linux-2.4.18-new/drivers/ide/ide-io.c 15 Sep 2003 20:11:12 -0000
> @@ -148,6 +148,7 @@
> ide_hwif_t *hwif = HWIF(drive);
> unsigned long flags;
> struct request *rq;
> + struct completion *waiting;
>
> spin_lock_irqsave(&io_request_lock, flags);
> rq = HWGROUP(drive)->rq;
> @@ -221,7 +222,13 @@
> spin_lock_irqsave(&io_request_lock, flags);
> blkdev_dequeue_request(rq);
> HWGROUP(drive)->rq = NULL;
> - end_that_request_last(rq);
> +
> + waiting = req->waiting;
> + req_finished_io(req);
> + blkdev_release_request(req);
> + if (waiting)
> + complete(waiting);
> +
> spin_unlock_irqrestore(&io_request_lock, flags);
> }
>

Did you ever built this ? req -> rq ?

--
J.A. Magallon <jamagallon@able.es> \ Software is like sex:
werewolf.able.es \ It's better when it's free
Mandrake Linux release 9.2 (Cooker) for i586
Linux 2.4.23-pre4-jam1 (gcc 3.3.1 (Mandrake Linux 9.2 3.3.1-2mdk))
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:48    [W:0.072 / U:0.908 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site