lkml.org 
[lkml]   [2003]   [Sep]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] might_sleep() improvements


    Mitchell Blank Jr wrote:

    >Andrew - I thought this might be appropriate for -mm kernels.
    >
    >This patch makes the following improvements to might_sleep():
    >
    > o Add a "might_sleep_if()" macro for when we might sleep only if some
    > condition is met. I think this is a bit better than the currently used
    > "if (cond) might_sleep();" since it's clearer that the test won't be
    > compiled in if spinlock sleep debugging is turned off. (Obviously
    > gcc is smart enough to omit simple conditions in that case) It also
    > looks cleaner, IMO. Think of it as analogous to BUG()/BUG_ON().
    >

    I think these should be pushed down to where the sleeping
    actually happens if possible.


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:48    [W:3.493 / U:0.524 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site