lkml.org 
[lkml]   [2003]   [Sep]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PM] Patrick: which part of "maintainer" and "peer review" needs explaining to you?
    On Mon, Sep 01 2003, Pavel Machek wrote:
    > Hi!
    >
    > > I think we need to expand the platform device support to include the
    > > notion of platform drivers. For example:
    > >
    > > struct platform_driver {
    > > int (*probe)(struct platform_device *);
    > > int (*remove)(struct platform_device *);
    > > int (*suspend)(struct platform_device *, u32);
    > > int (*resume)(struct platform_device *);
    > > struct device_driver drv;
    > > };
    > >
    > > (Aside: I like the movement of the suspend/resume methods to the bus_type,
    > > and I'd like to see the probe/remove methods also move there. For the
    > > vast majority of cases, the probe/remove methods in struct device_driver
    > > end up pointing at the same functions for any particular bus.)
    >
    > But what about those few devices that need special handling? Like
    > flush write cache on IDE disk but not on cdrom?

    ide-cd should have a flush write cache as well, for mtr, dvd-ram, cd-rw
    with packet writing, etc.

    --
    Jens Axboe

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    On Mon, Sep 01 2003, Pavel Machek wrote:
    > Hi!
    >
    > > I think we need to expand the platform device support to include the
    > > notion of platform drivers. For example:
    > >
    > > struct platform_driver {
    > > int (*probe)(struct platform_device *);
    > > int (*remove)(struct platform_device *);
    > > int (*suspend)(struct platform_device *, u32);
    > > int (*resume)(struct platform_device *);
    > > struct device_driver drv;
    > > };
    > >
    > > (Aside: I like the movement of the suspend/resume methods to the bus_type,
    > > and I'd like to see the probe/remove methods also move there. For the
    > > vast majority of cases, the probe/remove methods in struct device_driver
    > > end up pointing at the same functions for any particular bus.)
    >
    > But what about those few devices that need special handling? Like
    > flush write cache on IDE disk but not on cdrom?

    ide-cd should have a flush write cache as well, for mtr, dvd-ram, cd-rw
    with packet writing, etc.

    --
    Jens Axboe

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:48    [W:0.037 / U:61.172 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site