lkml.org 
[lkml]   [2003]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] kernel/futex.c: Uneeded memory barrier
    Date
    In message <20030913190242.GC7404@mail.jlokier.co.uk> you write:
    > If _all_ instances in the kernel of
    >
    > set_current_state(TASK_RUNNING)
    >
    > can be validly turned into
    >
    > __set_current_state(TASK_RUNNING)
    >
    > it would be good to make the barrier in set_current_state() itself
    > conditional on the state being state.

    Or eliminate the macro altogether, and create set_current_interruptible()
    and set_current_uninterruptible() which have the barrier, and let the normal
    users do the assignment the way God intended 8)

    In practice, those who care are using __, the rest aren't critical.

    Cheers,
    Rusty.
    --
    Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:48    [W:0.020 / U:63.324 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site