lkml.org 
[lkml]   [2003]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [2.6 patch] fix nfs4xdr.c compile warning
On Fri, Sep 12, 2003 at 12:40:39PM +1000, Neil Brown wrote:
>...
> > BTW:
> > Shouldn't the return values of nfsd4_encode_open{,_confirm,_downgrade}
> > be checked in the switch in nfsd4_encode_operation?
>
> No. There is nothing meaningful in their return values.

They return nfserr from ENCODE_SEQID_OP_TAIL.

If this isn't meaningful, should I send a patch that removes this return
from ENCODE_SEQID_OP_TAIL and changes these three functions to return
void?

> NeilBrown

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:48    [W:0.101 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site