lkml.org 
[lkml]   [2003]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] 2.4: Fix steal_locks race
From
On Sat, Aug 09, 2003 at 04:59:03AM +0200, Andreas Gruenbacher wrote:
>
> @@ -714,18 +715,16 @@ static int load_elf_binary(struct linux_
> elf_entry = load_elf_interp(&interp_elf_ex,
> interpreter,
> &interp_load_addr);
> -
> - allow_write_access(interpreter);
> - fput(interpreter);
> - kfree(elf_interpreter);
> -
> if (BAD_ADDR(elf_entry)) {
> printk(KERN_ERR "Unable to load interpreter\n");
> - kfree(elf_phdata);
> send_sig(SIGSEGV, current, 0);
> retval = -ENOEXEC; /* Nobody gets to see this, but.. */
> - goto out;
> + goto out_free_dentry;
> }
> +
> + allow_write_access(interpreter);
> + fput(interpreter);
> + kfree(elf_interpreter);
> }

This looks bad since you're past the point of no return.
--
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:47    [W:0.068 / U:2.784 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site