lkml.org 
[lkml]   [2003]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] Merge the changes from siimage 2.4.22-pre9 to 2.6.0-test2
Alan Cox <alan@lxorguk.ukuu.org.uk> wrote...
> > if(is_sata(hwif))
> > {
> > + drive->id->hw_config |= 0x6000;
> > if(strstr(drive->id->model, "Maxtor"))
> > return 3;
> > return 4;
> > }
>
> We never check the cable bits for SATA so this is a no-op

Alan,

Without this, in 2.4.22-pre10-ac1, ide_ata66_check() in ide-iops.c
returns 1. This causes, for example, that hdparm -i shows only udma
modes 0 to 2 (although the drive has been set to udma6) and refuses to
set any value above udma2 with an ugly "Speed warnings UDMA 3/4/5 is
not functional".

I do not understand the ide subsystem enough (I should say "at all"),
but maybe there are other implications...

Eduardo.



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:47    [W:0.049 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site