lkml.org 
[lkml]   [2003]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] AGPv3 command parsing
Date
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

there's a trivial but fatal typo in agp/generic.c:agp_v3_parse_one() that
completely messes up the command generation.

I'll let the attached patch against 2.6.0 explain the rest...

cu,
Nicolai
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)

iD8DBQE/MvsBsxPozBga0lwRAgsQAJ9AHqqG0uBXDKzE9pHxe1m67aZV2wCggBFH
p+BUB22EdrDIgvNs+kZHyVY=
=8khY
-----END PGP SIGNATURE-----
--- drivers/char/agp/generic.c~ 2003-08-08 03:05:06.000000000 +0200
+++ drivers/char/agp/generic.c 2003-08-08 03:05:06.000000000 +0200
@@ -453,9 +453,9 @@

/* Clear out unwanted bits. */
if (*cmd & AGPSTAT3_8X)
- *cmd = ~(AGPSTAT3_4X | AGPSTAT3_RSVD);
+ *cmd &= ~(AGPSTAT3_4X | AGPSTAT3_RSVD);
if (*cmd & AGPSTAT3_4X)
- *cmd = ~(AGPSTAT3_8X | AGPSTAT3_RSVD);
+ *cmd &= ~(AGPSTAT3_8X | AGPSTAT3_RSVD);
}

//FIXME: This doesn't smell right.
\
 
 \ /
  Last update: 2005-03-22 13:47    [W:0.063 / U:2.712 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site