[lkml]   [2003]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: Add identify decoding 4/4 wrote:
> Here a somewhat uneven commented ide_identify.h.
> This is part of a larger patch, but suffices for now.

Do you really want to stick that long function in a header?

Stick it in ide-lib.c, that's a better place for it, IMO...

No. <linux/ide-identify.h> contains a lot of 1-line static inline
functions, just readable names for current magic bit checks,
and one big function ide_dump_identify_info() that is included as

static void
ide_dump_identify_info(const struct hd_driveid *id, const char *name)

Thus, ide-floppy.c and ide-tape.c and isd200.c can do

#include <linux/ide-identify.h>

and get this big function, but only when their local debugging option
is set. We would not want to see it in the binary if there were no users.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2005-03-22 13:47    [W:0.036 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site