Messages in this thread | | | Date | Tue, 5 Aug 2003 12:18:41 +0200 (MEST) | From | Javier Achirica <> | Subject | Re: [PATCH] airo driver: fix races, oops, etc.. |
| |
On 5 Aug 2003, Benjamin Herrenschmidt wrote:
> On Tue, 2003-08-05 at 10:53, Javier Achirica wrote: > > I've integrated this patch in my code. I've done a major change: Instead > > of using schedule_delayed_work(), I create a new workqueue and use > > queue_work() on that queue. As all tasks sleep in the same lock, I can > > queue them there and make them sleep instead of requeueing them. > > > > I haven't sent them to Jeff yet, as I want to do more testing. If you want > > to help testing them, please tell me. > > Well... creating a work queue means you create one thread per CPU, that > sucks a bit don't think ? Maybe using a single thread for the driver > with your own queuing primitives...
You're right. In my PC, with just one CPU, it doesn't make a difference :-)
Anyway, I took a look at the workqueue code and looks like I only need a "create_workqueue()" that only creates one thread. This is what create_workqueue_thread() does, but it's static. Oh, well. I can also destroy all threads but one or, as you say, write my own code. I have to think about it....
Javier Achirica
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |