lkml.org 
[lkml]   [2003]   [Aug]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: 2.6.0-test2-mm4
On Mon, Aug 04, 2003 at 01:30:36AM -0700, Andrew Morton wrote:
> +4g4g-pmd-fix.patch

If you're going to back out pgd preconstruction, at least back it out
all the way so list poison isn't tripped over randomly on PAE. This is
actually worse than before, since you're basically doing list_del()
on whatever value of page->lru was handed to mm/slab.c from page_alloc.c
in pgd_dtor() multiple times per-page and pounding the lock for no
reason whatsoever on PAE. It's also degrading performance on non-PAE
due to the fact no preconstruction is done there, though harmless due
to the fact the only trace of pgd preconstruction left is the AGP fix.

Someone please tell me they realize this is a backout because absolutely
zero data structure initialization is done in ->ctor() and the entire
thing is memcpy()'d and memset()'d over in the front end to the slab.

I have no idea what, if anything has been absorbed from my prior posts
on this subject. AFAICT I'm getting dead air (or worse) back from
everyone else and no one's even bothering to read the code. i.e. either
no one understands a word I'm saying or no one's listening.


-- wli
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:47    [W:0.101 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site