Messages in this thread | | | Date | Sun, 31 Aug 2003 17:06:32 +0200 | From | Adrian Bunk <> | Subject | create_proc_entry and !CONFIG_PROC_FS |
| |
Hi,
I've observed a possible problem with create_proc_entry and !CONFIG_PROC_FS.
If !CONFIG_PROC_FS include/linux/proc_fs.h includes a dummy create_proc_entry that simply returns NULL.
Unfortunately, many callers of this function do things like e.g.
static int __init br2684_init(void) { struct proc_dir_entry *p; if ((p = create_proc_entry("br2684", 0, atm_proc_root)) == NULL) return -ENOMEM; p->proc_fops = &br2684_proc_operations; br2684_ioctl_set(br2684_ioctl); return 0; }
IOW, the dummy create_proc_entry fixes the compilation but the init function always returns -ENOMEM if !CONFIG_PROC_FS.
Is there any better solution than removing the dummy create_proc_entry and #ifdef'ing all places where it's used?
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |