lkml.org 
[lkml]   [2003]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH][2.6] ->release function for virtual EISA bridge
Driver isn't really broken, but removes warning.

EISA: Probing bus 0 at Intel Corp. 82375EB
EISA: Mainboard INT3190 detected.
EISA: Detected 0 cards.
Device 'eisa0' does not have a release() function, it is broken and must be fixed.
Badness in device_release at drivers/base/core.c:84
Call Trace:
[<c02cfb74>] kobject_cleanup+0x64/0x70
[<c0457131>] virtual_eisa_root_init+0x41/0x50
[<c06de82b>] do_initcalls+0x2b/0xa0
[<c01050f6>] init+0x56/0x210
[<c01050a0>] init+0x0/0x210
[<c0107125>] kernel_thread_helper+0x5/0x10

Index: linux-2.6.0-test2-mm2/drivers/eisa/virtual_root.c
===================================================================
RCS file: /build/cvsroot/linux-2.6.0-test2/drivers/eisa/virtual_root.c,v
retrieving revision 1.1.1.1
diff -u -p -B -r1.1.1.1 virtual_root.c
--- linux-2.6.0-test2-mm2/drivers/eisa/virtual_root.c 30 Jul 2003 00:06:12 -0000 1.1.1.1
+++ linux-2.6.0-test2-mm2/drivers/eisa/virtual_root.c 3 Aug 2003 07:39:47 -0000
@@ -22,6 +22,7 @@
#endif

static int force_probe = EISA_FORCE_PROBE_DEFAULT;
+static void virtual_eisa_release(struct device *);

/* The default EISA device parent (virtual root device).
* Now use a platform device, since that's the obvious choice. */
@@ -31,6 +32,7 @@ static struct platform_device eisa_root_
.id = 0,
.dev = {
.name = "Virtual EISA Bridge",
+ .release = virtual_eisa_release,
},
};

@@ -41,6 +43,12 @@ static struct eisa_root_device eisa_bus_
.slots = EISA_MAX_SLOTS,
.dma_mask = 0xffffffff,
};
+
+static void virtual_eisa_release (struct device *dev)
+{
+ /* nothing really to do here */
+ return;
+}

static int virtual_eisa_root_init (void)
{
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2005-03-22 13:47    [W:0.064 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site