lkml.org 
[lkml]   [2003]   [Aug]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2.6.0-test4][IPv6] ip6_flowlabel.c: timer cleanups
On 26 Aug 2003 19:54:41 +0530
Vinay K Nallamothu <vinay-rc@naturesoft.net> wrote:

> @@ -104,10 +105,9 @@
> fl->opt = NULL;
> kfree(opt);
> }
> - if (!del_timer(&ip6_fl_gc_timer) ||
> - (long)(ip6_fl_gc_timer.expires - ttd) > 0)
> - ip6_fl_gc_timer.expires = ttd;
> - add_timer(&ip6_fl_gc_timer);
> + if (!timer_pending(&ip6_fl_gc_timer) ||
> + time_after(ip6_fl_gc_timer.expires, ttd))
> + mod_timer(&ip6_fl_gc_timer, ttd);
> }
> }
>

This code is still racey. This code needs to hold the
toplevel ip6_fl_lock during the GC timer manipulations
and tests.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:48    [W:0.023 / U:0.940 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site