lkml.org 
[lkml]   [2003]   [Aug]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: PATCH odd code in bio_add_page
On Tue, Aug 26 2003, Neil Brown wrote:
>
> I was just taking a closer look at bio_add_page and there is some code
> that doesn't mage sense. The following patch explains the problem and
> suggests a possible fix.
>
> NeilBrown
>
>
> ==================================================
> Fix strange code in bio_add_page
>
> With the current code in bio_add_page, if fail_segments is ever set,
> it stays set, so bio_add_page will eventually fail having recounted
> the segmentation once.
>
> I don't think this is intended. This patch changes the code to allow
> success if the recounting the segments helps.

Good catch Neil, I agree with the fix.

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:48    [W:0.046 / U:0.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site