lkml.org 
[lkml]   [2003]   [Aug]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH][2.6][2/5]Support for HPET based timer
Andrew Morton <akpm@osdl.org> wrote:
>
> I doubt if we really need the timer running that early, apart from for
> calibrate_delay().
>
> You can probably move the time_init() and calibrate_delay() so they occur
> after mem_init(). A close review would be needed to see if that is likely
> to break anything. If it is, then consider creating a new late_time_init()
> thing, and call that and calibrate_delay() after mem_init().
>

Actually, I think some platforms (ppc64) will explode if we do the
local_irq_enable() prior to time_init().

So I suggest you look at the latter option:

- change time_init() so that it doesn't actually touch the HPET hardware
in the HPET timer case.

- add late_time_init() after mem_init().

- then do calibrate_delay().

Or whatever. The bottom line is that init/main.c is fragile, but not
inviolable ;)


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:48    [W:0.061 / U:0.964 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site