lkml.org 
[lkml]   [2003]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Cpufreq for opteron
Hi!

> It appears to me that the BUG_ON() macro will take the machine
> down ? The BUG_ON() checks in this code (a sample below, but
> this applies to all of the driver) are not fatal conditions -
> execution can continue if an error is returned. Taking the
> machine down to report on a non-fatal condition seems somewhat
> rude.

It is somewhat rude, but it makes sure that the error gets fixed. [And
it also appears safer to me: if we know error already happened we opt
to stop the system so nothing bad happens.]

Questions:

1) is it possible to do hardware damage from powernow-k8 driver?

2) should some of those checks be fatal?

3) for nonfatal checks, is it possible to use WARN_ON() -- warn and
continue?

4) given good hardware and debugged driver, will any of those
BUG_ON()s ever trigger?

Pavel
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:48    [W:0.034 / U:3.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site