Messages in this thread | | | Date | Mon, 25 Aug 2003 15:48:29 -0700 | From | David Hinds <> | Subject | Re: Trivial patch for drivers/serial/8250_cs |
| |
On Mon, Aug 25, 2003 at 11:27:08PM +0200, ???????????? ?????????????????????? wrote: > This patch is against 2.6.0-test4. > It fixes the pcmcia serial driver to know its now called 8250_cs and not > serial_cs... > > Without this patch 8250_cs compiles but doesn't work.
What do you mean by "doesn't work", exactly? The existing name should work if you have:
device "serial_cs" module "8250_cs"
in /etc/pcmcia/config. With your patch, it would work with:
device "8250_cs" module "8250_cs"
(and also changing every instance of serial_cs to 8250_cs)
> All the patch does is change several "serial_cs" occurences to "8250_cs". > > PS. > another possible sollution is to change everything (including the file > name) from "8250_cs" to "serial_cs" like it is in 2.4
I would say that "serial_cs" is more accurate since this is the driver for cards that conform to the standard for PCMCIA serial interfaces. Renaming to "8250_cs" is obfuscatory and pointlessly breaks config files for previous kernel versions. It is second in foolishness only to the genious who thought renaming "ide_cs" to "ide-cs" was a good idea.
-- Dave
P.S. -- your email name ('???...') is a good way to target your email to the spam bucket; I almost discarded it myself. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |