[lkml]   [2003]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 2.6.0-test4][NET] ni5010.c: remove cli/sti
Vinay wrote:

>This patch replaces cli/sti with spinlocks. Compiles fine though
I don't have the hardware either, but the patch seems to be wrong:
The cli() call was in hardware_send_packet(). I assume that this
function should be synchronized against concurrent interrupts - both
functions access the hardware. Due to the dev_xmit_lock, the networking
core already guarantees that hardware_send_packet is never reentered.
cli() provided protection against concurrent interrupts on other cpus,
spin_lock_irqsave() doesn't.

Could you add a spin_lock()/spin_unlock() into ni5010_interrupt?


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2005-03-22 13:48    [W:0.046 / U:9.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site