lkml.org 
[lkml]   [2003]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Cpufreq for opteron
On Fri, Aug 22, 2003 at 03:59:46PM +0200, Pavel Machek wrote:
> + tristate "AMD K8 PowerNow!"
> + depends on CPU_FREQ_TABLE

shouldn't be this

depends on CPU_FREQ?

> +#ifdef CONFIG_SMP
> +#error cpufreq support is disabled for config_smp
> +#endif

bah. better depend on !CONFIG_SMP in the Kconfig file.

> +/* driver entry point for term */
> +static void __exit
> +drv_exit(void)
> +{
> + dprintk(KERN_INFO PFX "drv_exit\n");
> +
> + cpufreq_unregister_driver(&cpufreq_amd64_driver);
> + if (ppst) {
> + kfree(ppst);

kfree(NULL) is fine.

> + ppst = 0;

this should be ppst = NULL but in fact is completly superflous as
the module is gone afterwards.

> + }
> + return;

superflous.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:48    [from the cache]
©2003-2011 Jasper Spaans