[lkml]   [2003]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PM] Patrick: which part of "maintainer" and "peer review" needs explaining to you?

Pavel Machek wrote:

> static int __init resume_setup(char *str)
> {
> - strncpy( resume_file, str, 255 );
> + if (strlen(str))
> + strncpy(resume_file, str, 255);
> return 1;
> }

Silly me, but if you want to check to be sure a string has a length
greater than zero, wouldn't it be faster to just check to be sure that
the first byte is not zero?

Think about how much work it does if the string is 100 characters long
when all you want to do is determine that it's non-zero.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2005-03-22 13:48    [W:0.148 / U:0.540 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site