lkml.org 
[lkml]   [2003]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] 'noapic' already handled elsewhere
I sent a previous patch to s/LOCAL_APIC/IO_APIC/, as Zwane noticed
my first patch needed that. In that patch, I commented __setup()
would be better.

Well... line 718 of arch/i386/kernel/io_apic.c _already_ handles this
case, using __setup() properly.

Word of warning... patch only compile tested, but seems obvious from
looking at io_apic.c.

BTW, why isn't ACPI using __setup() as well? I don't see that ACPI
needs to patch arch/i386/kernel/setup.c at all.


===== arch/i386/kernel/setup.c 1.94 vs edited =====
--- 1.94/arch/i386/kernel/setup.c Thu Aug 21 01:32:04 2003
+++ edited/arch/i386/kernel/setup.c Thu Aug 21 12:09:13 2003
@@ -544,12 +544,6 @@
if (!acpi_force) acpi_disabled = 1;
}

-#ifdef CONFIG_X86_LOCAL_APIC
- /* disable IO-APIC */
- else if (!memcmp(from, "noapic", 6)) {
- skip_ioapic_setup = 1;
- }
-#endif /* CONFIG_X86_LOCAL_APIC */
#endif /* CONFIG_ACPI_BOOT */

/*
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2005-03-22 13:47    [W:0.045 / U:3.444 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site